st/entry: Fix clutter action leak when unsetting icon

The name of the removed action did not match the added one anymore,
effectively "leaking" an action whenever an icon was shown and hidden.
This was primarily affecting the clear button in the shell search.

Fixes: 0bf49afda ("Replace ClutterClickAction with new ClutterClickGesture")
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4095>

diff --git a/src/st/st-entry.c b/src/st/st-entry.c
index cf13331b3bb2f6d82738df7024e2e387f68b0711..ce3e08be31e115a1d8c811b1224c25bc60d30711 100644 (file)
--- a/src/st/st-entry.c
+++ b/src/st/st-entry.c
@@ -1292,7 +1292,7 @@ _st_entry_set_icon (StEntry       *entry,
 {
   if (*icon)
     {
-      clutter_actor_remove_action_by_name (*icon, "entry-icon-action");
+      clutter_actor_remove_action_by_name (*icon, "entry-icon-click-gesture");
       clutter_actor_remove_child (CLUTTER_ACTOR (entry), *icon);
       *icon = NULL;
     }